Fix FHIR converter sample requests #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 48 48
Lines 2811 2811
=======================================
Hits 2719 2719
Misses 92 92
Flags with carried forward coverage won't be shown. Click here to find out more. |
robertmitchellv
approved these changes
Nov 29, 2023
| @@ -43,7 +45,10 @@ async def health_check(): | |||
| status_code=200, | |||
| responses=sample_response, | |||
| ) | |||
| async def convert(input: FhirConverterInput, response: Response): | |||
| async def convert( | |||
| input: Annotated[FhirConverterInput, Body(examples=sample_request)], | |||
There was a problem hiding this comment.
this is a neat way to do this 🚀
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Adds dropdown options for different sample requests to the API docs for our FHIR converter. All 3 sample messages were tested and work for the FHIR converter.
Related Issue
Fixes #937
Additional Information
This method of setting multiple API docs probably will break when we upgrade to the latest version of FastAPI - some changes were introduced in 0.99 (we're on 0.96 at time of writing). See more here.
Screenshots
Checklist