Add CGAL::IO::read_OM() #8427
Open
Add CGAL::IO::read_OM() #8427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaelRL
added
the
Not yet approved
…s' into BGL-Openmesh_selection-GF # Conflicts: # BGL/examples/BGL_OpenMesh/CMakeLists.txt
janetournois
added
the
depends on another PR
|
In the demo, loading a .om file containing a surface mesh that has no feature vertices and no feature edges should not create a selection item. |
janetournois
removed
the
depends on another PR
|
|
|
Failed in 6.0-Ic-327 and must be tested again. Fix is committed. |
sloriot
reviewed
Sep 25, 2024
sloriot
reviewed
Sep 25, 2024
sloriot
reviewed
Sep 25, 2024
sloriot
reviewed
Sep 25, 2024
sloriot
reviewed
Sep 25, 2024
sloriot
reviewed
Sep 25, 2024
sloriot
reviewed
Sep 25, 2024
I guess you are missing something in the cmake list of the plugin |
Co-authored-by: Sebastien Loriot <[email protected]>
Co-authored-by: Sebastien Loriot <[email protected]>
sloriot
reviewed
Oct 8, 2024
|
Co-authored-by: Sebastien Loriot <[email protected]>
|
ICE on MSVC 2022. See here |
|
Actually there is also an ICE here so maybe it has nothing to do with this PR |
|
Successfully tested in CGAL-6.0.1-Ic-351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add a function to read an OpenMesh file (
*.om) in CGALlab. This file format stores also edges and vertices marked as features.For the moment the function itself is not documented.
Release Management
FindOpenMesh.cmake#8332