Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove db_clean service from docker-compose.yml #136

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Conversation

rpdelaney
Copy link
Contributor

EASI-340

Changes proposed in this pull request:

  • Remove db_clean container from docker-compose.yml

A race condition between the migration containers was causing the database to sometimes get cleaned after migrations had been run. Rather than hack together scripts to track this state I'm simply removing the clean service from the docker-compose configuration.

See also:

Note: After pulling this change locally, start once with docker-compose up --remove-orphans to clear out the orphaned db_clean image. After that, the services can be started normally with just docker-compose up.

A race condition between these two containers was causing the database
to sometimes get cleaned after migrations had been run. Rather than hack
together scripts to track this state I'm simply removing the clean
service from the docker-compose configuration.

See also:
  * https://docs.docker.com/compose/startup-order/
  * docker/compose#374
@rpdelaney rpdelaney requested a review from a team April 9, 2020 19:54
@rpdelaney rpdelaney merged commit bcb3f8c into master Apr 9, 2020
@rpdelaney rpdelaney deleted the easi-340 branch April 9, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants