Add env var feature flag to enable queueing library #1004
+149
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpartridge
force-pushed
the
carl/BCDA-8426-enable-swappable-queuing-library
branch
from
7605b2d
to
130b32d
Compare
carlpartridge
commented
Oct 17, 2024
| @@ -632,6 +632,7 @@ func (h *Handler) bulkRequest(w http.ResponseWriter, r *http.Request, reqType se | |||
| sinceParam := (!rp.Since.IsZero() || conditions.ReqType == service.RetrieveNewBeneHistData) | |||
| jobPriority := h.Svc.GetJobPriority(conditions.CMSID, j.ResourceType, sinceParam) // first argument is the CMS ID, not the ACO uuid | |||
|
|
|||
| logger.Infof("Adding jobs using %T", h.Enq) | |||
There was a problem hiding this comment.
Sanity check logging that we are are using the proper queueing library. I dont totally understand why we seem to have different loggers and different access to them?
carlpartridge
commented
Oct 17, 2024
| return riverEnqueuer{} | ||
| } else { | ||
| panic("NO QUEUE LIBRARY SET") | ||
| } |
There was a problem hiding this comment.
Not sure if panic-ing is better than just defaulting to a specific library?
There was a problem hiding this comment.
If we're going to a green-blue solution for the libraries I'd just default to que-go.
carlpartridge
commented
Oct 17, 2024
| @@ -67,3 +74,13 @@ func (q queEnqueuer) AddAlrJob(job models.JobAlrEnqueueArgs, priority int) error | |||
|
|
|||
| return q.Enqueue(j) | |||
| } | |||
|
|
|||
| type riverEnqueuer struct{} | |||
There was a problem hiding this comment.
Dummy type and interface for now.
carlpartridge
commented
Oct 17, 2024
| @@ -10,6 +10,7 @@ BCDA_WORKER_ERROR_LOG=/var/log/worker/error.log | |||
| DEBUG=true | |||
| DEPLOYMENT_TARGET=dev | |||
| EXPIRED_THRESHOLD_HR=24 | |||
| QUEUE_LIBRARY=que-go | |||
There was a problem hiding this comment.
These files are the non-sensitive env vars used for each environment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8426
🛠 Changes
Enable swapping of queueing libraries based on env var.
ℹ️ Context
This is an initial stepping stone in the process of replacing our queueing library. This PR specifically sets up the ability to switch between queueing libraries with a restart. See https://confluence.cms.gov/display/BCDA/2024-09-26%3A+Replace+Queue+Library for more context.
🧪 Validation
Full test suite and linting pass.