Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parwinder/bcda 8414 enable linters #1005

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Parwinder/bcda 8414 enable linters #1005

wants to merge 32 commits into from

Conversation

bhagatparwinder
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/BCDA-8414

🛠 Changes

Enabled linters and fixed all open issues

ℹ️ Context

We updated dependencies in the last sprint. During that update, we realized our golangci file was misnamed, and we were not testing for lint issues. The linters were disabled temporarily. This change is to enable them again and fix outstanding issues.

🧪 Validation

Ran linter locally

image

@bhagatparwinder bhagatparwinder marked this pull request as ready for review October 21, 2024 19:06
@bhagatparwinder bhagatparwinder requested a review from a team October 21, 2024 19:06
carlpartridge
carlpartridge reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@carlpartridge carlpartridge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There are a few places where we are ignoring an error that I would like to verify just to be super safe. The failing check could possibly be related to the updates to the platinum image?

.golangci.yml Show resolved Hide resolved
bcda/api/requests_test.go Outdated Show resolved Hide resolved
bcda/auth/middleware_test.go Show resolved Hide resolved
bcda/models/postgres/repository_test.go Outdated Show resolved Hide resolved
bcdaworker/main_test.go Show resolved Hide resolved
bcdaworker/repository/postgres/repository_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlpartridge carlpartridge Awaiting requested review from carlpartridge

@laurenkrugen-navapbc laurenkrugen-navapbc Awaiting requested review from laurenkrugen-navapbc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhagatparwinder @carlpartridge @laurenkrugen-navapbc