Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPC-4278] Content updates for default welcome page #2284

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

lukey-luke
Copy link
Contributor

@lukey-luke lukey-luke commented Oct 8, 2024

🎫 Ticket

DPC-4278

🛠 Changes

  • remove lorem ipsum placeholder text for /portal/users/sign_in and use latest content provided by design
  • Source of truth for content under "Page for returning users to sign in" on Confluence doc HERE.
  • link to sandbox on the right side of the page

ℹ️ Context

  • Lorem ipsum placeholder text was used beforehand.

🧪 Validation

  • manually verified the content updates by running
  • make portal && make start-portal then navigating to http://localhost:3100/portal/users/sign_in
  • see also updates to dpc-portal/spec/components/page/session/login_component_spec.rb

@lukey-luke lukey-luke marked this pull request as ready for review October 8, 2024 20:02
@lukey-luke lukey-luke changed the title Content updates for default welcome page [DPC-4278] Content updates for default welcome page Oct 8, 2024
@lukey-luke lukey-luke requested a review from a team October 8, 2024 20:05
Copy link
Contributor

@MEspositoE14s MEspositoE14s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good when I run it on my machine!

@lukey-luke lukey-luke merged commit f720795 into main Oct 9, 2024
8 checks passed
@lukey-luke lukey-luke deleted the ls/feature-4278-default-welcome-content-updates branch October 9, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants