Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove byte-order mark from JSON stream and first CSV chunk #53

Merged
merged 4 commits into from
Aug 20, 2024

Commits on Aug 11, 2024

  1. Remove BOM from JSON stream

    When JSON input is a readable stream, a byte-order mark may be present
    at the beginning of the stream. When reading the first chunk of the
    stream, check for the presence of the byte-order mark. Remove it if it
    is present.
    mint-thompson committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    629886a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Remove BOM when parsing CSV

    When parsing a CSV from a source that includes a byte-order mark (BOM),
    the BOM is present at the time the parser attempts to determine if the
    first column name is quoted. When the BOM is present, the parser does
    not recognize that the column is quoted, resulting in a failure to match
    an expected column name. Remove the BOM (if present) from the first
    chunk so that a quoted column name will be recognized and parsed as a
    quoted value.
    mint-thompson committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    984cb6d View commit details
    Browse the repository at this point in the history
  2. minor refactor to DRY up BOM

    shaselton authored and shaselton committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    4a531a9 View commit details
    Browse the repository at this point in the history
  3. always forgetting to pretty fix

    shaselton authored and shaselton committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    f2ff8b3 View commit details
    Browse the repository at this point in the history