Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rusticl with closver-mesa #118

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Replace rusticl with closver-mesa #118

merged 1 commit into from
Jun 27, 2024

Conversation

ptr1337
Copy link
Member

@ptr1337 ptr1337 commented Jun 27, 2024

Rusticl seems to break on Hybrid Laptops CUDA and with it Davinci Resolve and several other applications.

These tools seems to prefer it over cuda and somehow even disables cuda then.

I also remove rocm-opencl-runtime to be safe. We can handle further automatic rocm installation via AI_SDK.

@ptr1337 ptr1337 requested review from ventureoo and vnepogodin and removed request for ventureoo June 27, 2024 20:22
Copy link
Member

@vnepogodin vnepogodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnepogodin vnepogodin merged commit 486aa87 into master Jun 27, 2024
2 checks passed
@vnepogodin vnepogodin deleted the drop-rusticl branch June 27, 2024 20:38
@ventureoo
Copy link
Member

If we remove the Rusticl drivers from the profile, we break Davinci and some other programs out of the box for those with only AMD/Intel and no hybrid graphics, so we should just put rusticl in conditional_packages instead of just removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants