Fix parenthesis bug in _isCoPlanar function (#1451)

* Add test demonstrating parenthesis bug * Fix parenthesis bug in `_isCoPlanar` function
CadQuery · Dec 3, 2023 · 6869dc6 · 6869dc6
1 parent 2504d6b
commit 6869dc6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/cadquery/cq.py b/cadquery/cq.py
@@ -570,7 +570,7 @@ def _isCoPlanar(f0, f1):
  return False
 
  # test if p1 is on the plane of f0 (offset of planes)
- return abs(n0.dot(p0.sub(p1)) < self.ctx.tolerance)
+ return abs(n0.dot(p0.sub(p1))) < self.ctx.tolerance
 
  def _computeXdir(normal):
  """

diff --git a/tests/test_cadquery.py b/tests/test_cadquery.py
@@ -1613,6 +1613,10 @@ def testMultiFaceWorkplane(self):
  self.assertAlmostEqual(o.y, 0.0, 3)
  self.assertAlmostEqual(o.z, 0.5, 3)
 
+ # Test creation with non-co-planar faces fails
+ with raises(ValueError):
+ w = s.faces("+Y").workplane()
+
  def testTriangularPrism(self):
  s = Workplane("XY").lineTo(1, 0).lineTo(1, 1).close().extrude(0.2)
  self.saveModel(s)