Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workplane polarArray incorrect startAngle and angle (according to its docstring and convention) #1006

Closed
lorenzncode opened this issue Feb 19, 2022 · 1 comment · Fixed by #1016
Closed

Workplane polarArray incorrect startAngle and angle (according to its docstring and convention) #1006

lorenzncode opened this issue Feb 19, 2022 · 1 comment · Fixed by #1016
Labels
sketching

Comments

@lorenzncode
Copy link
Member

From the polarArray docstring:

        :param startAngle: Starting angle (degrees) of array. 0 degrees is
            situated along local X-axis.
        :param angle: The angle (degrees) to fill with elements. A positive
            value will fill in the counter-clockwise direction.

Would you be opposed to correcting polarArray behavior to follow the docstring?

There are no doc examples and few other references of usage. I think the issue wasn't noticed because usage was typically with angle=360 e.g. #118.
@adam-urbanczyk
Copy link
Member

Yes, +1

lorenzncode added a commit to lorenzncode/cadquery that referenced this issue Feb 27, 2022
@lorenzncode
polarArray start angle, and rotation fix (CadQuery#1006)
a3d937d
@lorenzncode lorenzncode mentioned this issue Feb 27, 2022
Merged
adam-urbanczyk pushed a commit that referenced this issue Mar 20, 2022
@lorenzncode
polarArray start angle, and rotation fix (#1006) (#1016)
3efb080 
* polarArray start angle, and rotation fix (#1006)

* * Add TOL module constant
* Remove nested function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sketching
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

polarArray start angle, and rotation fix (#1006) lorenzncode/cadquery
2 participants
@adam-urbanczyk @lorenzncode