Sketch parray fix

[lorenzncode]

• Start angle and rotation convention to be consistent with arc Sketch parray inconsistent start angle and rotation convention #1001
• Fix parray bug when used with push
• Return n locations for 360 degree array
• Fix n=1

With current PR changes:

s = cq.Sketch().parray(20, 20, -70, 8).circle(0.5)

s = cq.Sketch().parray(4, 0, 180, 6).rect(1, 0.5)

s = cq.Sketch().push([(5,5)]).parray(4, 20, 360, 6).rect(1, 0.5)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (9e9b452) to head (d4070b4).
Report is 379 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1005   +/-   ##
=======================================
  Coverage   96.26%   96.27%           
=======================================
  Files          40       40           
  Lines        9344     9357   +13     
  Branches     1104     1103    -1     
=======================================
+ Hits         8995     9008   +13     
  Misses        205      205           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adam-urbanczyk]

Thanks @lorenzncode , some minor points from my side.

[jmwright]

Thanks @lorenzncode

Is this ready to merge?

[lorenzncode]

It's ready to merge unless any additional review changes are requested. Regarding the following changes do let me know if there is an issue.

1. Arg a2 changed to da. Initially I did not feel strongly about this part. After testing I leaned toward making this consistent with arc as well.
   Consider distributing over a half circle:

   • a2: parray(10, 70, 70+180, 6)
   • da: parray(10, 70, 180, 6)

2. Distributing over a full circle - special handling was added to generate n requested locations.

[adam-urbanczyk]

@lorenzncode LGTM!