Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multimethod pin. #1118

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

lorenzncode
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1118 (8481f0c) into master (53045e7) will not change coverage.
The diff coverage is n/a.

❗ Current head 8481f0c differs from pull request most recent head 370f2b1. Consider uploading reports for the commit 370f2b1 to get more accurate results

@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          40       40           
  Lines        9648     9648           
  Branches     1272     1272           
=======================================
  Hits         9293     9293           
  Misses        210      210           
  Partials      145      145           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lorenzncode
Copy link
Member Author

This change is to resolve the intermittent failures of test_cadquery.py::TestCadQuery::test_project.
Likely coady/multimethod#53

@lorenzncode lorenzncode marked this pull request as ready for review July 11, 2022 23:59
@adam-urbanczyk
Copy link
Member

Perfect, thanks @lorenzncode ! Simple and important fix - merging.

@adam-urbanczyk adam-urbanczyk merged commit f1b8763 into CadQuery:master Jul 12, 2022
@lorenzncode lorenzncode deleted the multimethod-pin branch July 15, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants