Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not recompute normals when converting to vtk #1167

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Do not recompute normals when converting to vtk #1167

merged 2 commits into from
Oct 6, 2022

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Oct 4, 2022 •
edited
Loading

Solves #1158

@adam-urbanczyk adam-urbanczyk mentioned this pull request Oct 4, 2022
Closed
@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Merging #1167 (13c1d09) into master (d5806e3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1167   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          26       26           
  Lines        5411     5411           
  Branches      918      918           
=======================================
  Hits         5087     5087           
  Misses        193      193           
  Partials      131      131
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 92.65% <ø> (ø)
cadquery/occ_impl/exporters/vtk.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mojca
Copy link

mojca commented Oct 5, 2022

Thank you very much, this seems to have solved the problem reported in #1158.

lorenzncode
lorenzncode approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@lorenzncode lorenzncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'box-has-back-face-culling-issues.wrl' before fix (here in blender with WeightedNormal):
image

with this PR:
image

jmwright
jmwright approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk Looks good.

@jmwright jmwright merged commit 25290e8 into master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwright jmwright jmwright approved these changes

@lorenzncode lorenzncode lorenzncode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adam-urbanczyk @mojca @jmwright @lorenzncode