Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assembly constraint docs #1210

Merged
merged 1 commit into from
Dec 24, 2022
Merged

Conversation

lorenzncode
Copy link
Member

  • Correct FixedPoint constraint example
  • Simplify Location usage in examples and format with black for consistency

* Correct FixedPoint constraint example
* Simplify Location usage in examples and format with black for consistency
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #1210 (d71458a) into master (e23f43d) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
+ Coverage   94.01%   94.07%   +0.05%     
==========================================
  Files          26       26              
  Lines        5414     5414              
  Branches      919      919              
==========================================
+ Hits         5090     5093       +3     
+ Misses        193      190       -3     
  Partials      131      131              
Impacted Files Coverage Δ
cadquery/cqgi.py 80.73% <0.00%> (+1.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lorenzncode lorenzncode marked this pull request as ready for review December 23, 2022 05:23
@lorenzncode
Copy link
Member Author

Fixes #1159.

I removed a note on STEP and transparency. I find that STEP export includes transparency data so the note may be out of date.

@jmwright
Copy link
Member

I created a test assembly with transparency and exported to STEP. Then I imported that into the online Autodesk viewer because the version of FreeCAD I'm running doesn't seem to respect the color info. Seems to confirm that transparency works.

Screenshot from 2022-12-23 16-37-08

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lorenzncode !

@lorenzncode
Copy link
Member Author

@jmwright Thanks for confirming transparency is working for you! Regarding colors, PR #1157 attempts to resolve an issue with STEP export and color handling. I've tested STEP export with the PR branch and several viewers, including FreeCAD and Autodesk, and did not find any problem. You might try exporting the STEP again with the PR 1157 branch to see if it resolves the color issue when viewing in FreeCAD.

@lorenzncode lorenzncode linked an issue Dec 23, 2022 that may be closed by this pull request
@jmwright
Copy link
Member

@lorenzncode I just tested in FreeCAD 0.20.1 and the color and alpha worked, but I had to turn off the STEP import option Enable STEP compound merge which is apparently on by default. If that setting is not turned off I get two default grey merged blocks.

Screenshot from 2022-12-23 18-00-57

@jmwright jmwright merged commit 1eb14fc into CadQuery:master Dec 24, 2022
@lorenzncode lorenzncode deleted the 1159-docs branch February 26, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FixedPoint constraint's example is a copy / paste of PointOnLine's
3 participants