Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment.yml cleanup #1233

Merged
merged 3 commits into from
Jan 14, 2023
Merged

environment.yml cleanup #1233

merged 3 commits into from
Jan 14, 2023

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Jan 14, 2023

Do not install deps when pip installing cadquery from a conda/mamba env

Solves #1228

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #1233 (0b19ed8) into master (4745ad1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1233   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          26       26           
  Lines        5432     5432           
  Branches      919      919           
=======================================
  Hits         5111     5111           
  Misses        190      190           
  Partials      131      131           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lorenzncode lorenzncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleanup looks good. I tested the PR by creating a new conda env from the yml file with mambaforge mamba 1.0.0, conda 22.9.0.

Actually my prior install I applied the workaround:
export CONDA_PY=1
This workaround is no longer required.

@adam-urbanczyk adam-urbanczyk linked an issue Jan 14, 2023 that may be closed by this pull request
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @adam-urbanczyk

@jmwright jmwright merged commit a2c1f7c into master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create dev environment. OCP version
3 participants