Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Workplane.close bug with 3D points #1271

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

lorenzncode
Copy link
Member

Resolves #1253

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #1271 (24c2496) into master (2997a3a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
+ Coverage   94.09%   94.11%   +0.02%     
==========================================
  Files          26       26              
  Lines        5433     5435       +2     
  Branches      920      921       +1     
==========================================
+ Hits         5112     5115       +3     
+ Misses        190      189       -1     
  Partials      131      131              
Impacted Files Coverage Δ
cadquery/cq.py 92.19% <100.00%> (ø)
cadquery/occ_impl/shapes.py 92.75% <0.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lorenzncode

@jmwright jmwright merged commit 9c519e6 into CadQuery:master Feb 25, 2023
@lorenzncode lorenzncode deleted the 1253-close branch February 26, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close does not work as expeted
3 participants