Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs - Update installation instructions and advise to use mambaforge #1362

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

lorenzncode
Copy link
Member

Closes #691

I think many of us have been using mamba install for some time with good results.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #1362 (802d2a3) into master (5bce8d0) will not change coverage.
The diff coverage is n/a.

❗ Current head 802d2a3 differs from pull request most recent head 069c73c. Consider uploading reports for the commit 069c73c to get more accurate results

@@           Coverage Diff           @@
##           master    #1362   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          27       27           
  Lines        5671     5671           
  Branches      961      961           
=======================================
  Hits         5338     5338           
  Misses        199      199           
  Partials      134      134           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lorenzncode
Copy link
Member Author

Closes #1369

README.md Show resolved Hide resolved
Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues in the README

README.md Show resolved Hide resolved
* README.md - Add link to Mambaforge, note on mamba install
* installation.rst - Version 2.3.1 install example, conda vs mamba, add link to mamba docs
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use mamba and so I don't have a lot of knowledge about it, but the changes look fine to me.

@adam-urbanczyk adam-urbanczyk merged commit 56c9bda into CadQuery:master Aug 10, 2023
1 check passed
@lorenzncode lorenzncode deleted the docs-mamba-install branch August 19, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly advise to use miniconda
5 participants