Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty render in docs and doc build error #1367

Merged
merged 3 commits into from
Jul 8, 2023

Conversation

lorenzncode
Copy link
Member

Closes #1364

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1367 (1f4ee77) into master (44ae035) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 1f4ee77 differs from pull request most recent head 57d815a. Consider uploading reports for the commit 57d815a to get more accurate results

@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   94.15%   94.10%   -0.06%     
==========================================
  Files          26       26              
  Lines        5611     5611              
  Branches      956      956              
==========================================
- Hits         5283     5280       -3     
- Misses        195      198       +3     
  Partials      133      133              
Impacted Files Coverage Δ
cadquery/occ_impl/assembly.py 97.27% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lorenzncode lorenzncode marked this pull request as draft July 6, 2023 19:59
@lorenzncode
Copy link
Member Author

I'll revert to the previous version of the assembly doc example. To avoid the cqgi error, the unsupported parameter type can be skipped. Perhaps with a future enhancement cqgi can support additional parameter types.

@lorenzncode lorenzncode marked this pull request as ready for review July 6, 2023 22:51
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lorenzncode

Should we create an issue for adding tuple support to CQGI?

@lorenzncode
Copy link
Member Author

Should we create an issue for adding tuple support to CQGI?

Done, opened #1370

@adam-urbanczyk
Copy link
Member

Thanks @lorenzncode !

@adam-urbanczyk adam-urbanczyk merged commit 1257622 into CadQuery:master Jul 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FixedAxis assembly constraint VTK render is broken
3 participants