Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make segments names more clear in test_constraint_solver() #1379

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

sanderobdeijn
Copy link
Contributor

Fix for #1378

@sanderobdeijn
Copy link
Contributor Author

I didn't change the sketch variable names because the Sx seems to be the standard in all the tests. But I could also change those to sketch1, 2, etc

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #1379 (98a99c9) into master (da6354f) will not change coverage.
The diff coverage is n/a.

❗ Current head 98a99c9 differs from pull request most recent head 4786aed. Consider uploading reports for the commit 4786aed to get more accurate results

@@           Coverage Diff           @@
##           master    #1379   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          27       27           
  Lines        5671     5671           
  Branches      961      961           
=======================================
  Hits         5338     5338           
  Misses        199      199           
  Partials      134      134           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanderobdeijn !

@jmwright jmwright merged commit ad46448 into CadQuery:master Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants