Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line numbers in QuickStart section #1380

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Fix line numbers in QuickStart section #1380

merged 1 commit into from
Jul 24, 2023

Conversation

sethfischer
Copy link
Contributor

Update line numbers in the prose of the QuickStart section. These line numbers changed after formatting the code blocks with black.

@sethfischer
Fix line numbers in QuickStart section
32f400a 
Update line numbers in the prose of the QuickStart section. These line
numbers changed after formatting the code blocks with black.
@sethfischer
Copy link
Contributor Author

This is something I missed in #1220.

@codecov
Copy link

codecov bot commented Jul 22, 2023 •
edited
Loading

Codecov Report

Merging #1380 (22e4ac9) into master (5bce8d0) will not change coverage.
The diff coverage is n/a.

❗ Current head 22e4ac9 differs from pull request most recent head 32f400a. Consider uploading reports for the commit 32f400a to get more accurate results

@@           Coverage Diff           @@
##           master    #1380   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          27       27           
  Lines        5671     5671           
  Branches      961      961           
=======================================
  Hits         5338     5338           
  Misses        199      199           
  Partials      134      134

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sethfischer sethfischer marked this pull request as ready for review July 22, 2023 22:03
jmwright
jmwright approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up @sethfischer

@adam-urbanczyk
Copy link
Member

Thanks @sethfischer !

@adam-urbanczyk adam-urbanczyk merged commit bc82cb0 into CadQuery:master Jul 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwright jmwright jmwright approved these changes

@adam-urbanczyk adam-urbanczyk adam-urbanczyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethfischer @adam-urbanczyk @jmwright