Fix for incorrect tapered extrude height found in #1383 #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1388 +/- ##
==========================================
- Coverage 94.12% 94.12% -0.01%
==========================================
Files 27 27
Lines 5671 5670 -1
Branches 961 961
==========================================
- Hits 5338 5337 -1
Misses 199 199
Partials 134 134
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1383
It seems that LocOpe_DPrism is introducing the issue fround in #1383 where the extrude height requested by the user is not respected. I compensated for this in the code and then added a test so we can detect if the behavior ever changes in OCCT.