Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust initialization of the vtk window #1394

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Aug 31, 2023

Maybe fixes this problem
#1366 (comment)

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1394 (24e5469) into master (e8d7447) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 24e5469 differs from pull request most recent head ac21e5a. Consider uploading reports for the commit ac21e5a to get more accurate results

@@           Coverage Diff           @@
##           master    #1394   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files          27       27           
  Lines        5678     5678           
  Branches      962      962           
=======================================
  Hits         5345     5345           
  Misses        199      199           
  Partials      134      134           
Files Changed Coverage Δ
cadquery/vis.py 96.55% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good @adam-urbanczyk but it did not seem to fix the problem for users in the linked issue. However, I don't think this change will hurt anything, and could eliminate a possible race condition on initialization.

@adam-urbanczyk
Copy link
Member Author

I'll merge then.

@adam-urbanczyk adam-urbanczyk merged commit 8b7189d into master Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants