Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dxf splines and ellipse import support #406

Merged
merged 6 commits into from
Jul 17, 2020
Merged

dxf splines and ellipse import support #406

merged 6 commits into from
Jul 17, 2020

Conversation

adam-urbanczyk
Copy link
Member

Will resolve #373

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #406 into master will decrease coverage by 0.00%.
The diff coverage is 92.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   93.56%   93.55%   -0.01%     
==========================================
  Files          19       19              
  Lines        5083     5139      +56     
  Branches      523      530       +7     
==========================================
+ Hits         4756     4808      +52     
- Misses        205      209       +4     
  Partials      122      122              
Impacted Files Coverage Δ
cadquery/occ_impl/importers.py 87.50% <90.69%> (+1.60%) ⬆️
tests/test_importers.py 93.75% <100.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8707ce...6d6da05. Read the comment docs.

@adam-urbanczyk
Copy link
Member Author

@jmwright @dcowden do you have examples of dxf files with splines/rational splines?

@jmwright
Copy link
Member

@adam-urbanczyk I don't have any at hand, no.

@adam-urbanczyk adam-urbanczyk changed the title dxf splines and ellipse import support [WIP] dxf splines and ellipse import support Jul 17, 2020
@adam-urbanczyk
Copy link
Member Author

I think it is ready. NB: I generated rational spline in ezdxf and imported it for the lack of a better test method. It seems to be working fine, random drawings exported from Inkscape import fine. Not all operations work well for all geometries though (filleting is picky) but I was always able to extrude the solid. Still an experimental feature but I think it is as good as it gets for now.

obraz

@jmwright
Copy link
Member

Looks good as far as I can tell, thanks!

@jmwright jmwright merged commit 9ab2678 into master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DXF import spline and ellipse support
2 participants