Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose intersection joint type for shell #413

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Conversation

adam-urbanczyk
Copy link
Member

This PR will enable keeping sharp edges when shelling outwards

image

res1= cq.Workplane().box(1,1,1).faces('>Z').shell(.4,kind='intersection')

res2= cq.Workplane(origin=(3,0,0)).box(1,1,1).faces('>Z').faces('>Z').shell(.4,kind='arc')

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #413 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files          19       19           
  Lines        5142     5147    +5     
  Branches      530      530           
=======================================
+ Hits         4811     4816    +5     
  Misses        209      209           
  Partials      122      122           
Impacted Files Coverage Δ
cadquery/cq.py 87.93% <100.00%> (ø)
cadquery/occ_impl/shapes.py 90.68% <100.00%> (+0.01%) ⬆️
tests/test_cadquery.py 98.98% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ea7b8...8efb8ac. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, thanks for adding this.

@jmwright jmwright merged commit 8c864e1 into master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants