Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tessellate #420

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Fix tessellate #420

merged 2 commits into from
Aug 4, 2020

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Aug 3, 2020 •
edited
Loading

Will resolve #416

@adam-urbanczyk adam-urbanczyk mentioned this pull request Aug 3, 2020
Closed
@codecov
Copy link

codecov bot commented Aug 3, 2020 •
edited
Loading

Codecov Report

Merging #420 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   93.59%   93.59%   -0.01%     
==========================================
  Files          25       25              
  Lines        5291     5306      +15     
  Branches      548      552       +4     
==========================================
+ Hits         4952     4966      +14     
  Misses        215      215              
- Partials      124      125       +1
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 90.74% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1f8f3...5120642. Read the comment docs.

jmwright
jmwright approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-urbanczyk Looks, good. Thanks for fixing this.

@jmwright jmwright merged commit 5f67eb8 into master Aug 4, 2020
@jmwright jmwright mentioned this pull request Aug 4, 2020
Merged
@jmwright jmwright deleted the tessellate-fix branch May 24, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwright jmwright jmwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken TJS and AMF exports
2 participants
@adam-urbanczyk @jmwright