Create a child workplane on a vertex #480
Conversation
|
I'm not sure what mypy is wanting from me in the travisCI build. My logic should only be ran when the cq object is a Face (which has the normalAt() attribute. |
|
The mypy stuff is still a mystery to me, but the signature in the lint error matches CQObject. So maybe mypy at least thinks you're grabbing the wrong level of object? @adam-urbanczyk will know, I'm sure. |
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
+ Coverage 93.63% 93.65% +0.02%
==========================================
Files 30 30
Lines 5859 5880 +21
Branches 624 626 +2
==========================================
+ Hits 5486 5507 +21
Misses 234 234
Partials 139 139
Continue to review full report at Codecov.
|
|
Thanks @ArmoredBlood . Mypy does not know that the result of Looks good to me, @jmwright any thoughts? |
|
+1 to merge |
|
Thanks for the contribution @ArmoredBlood |
* add parent face detection to workplane() * Update cq.py * add nonetype check and tests * fixed test formatting * mypy fix attempt Co-authored-by: Adam Urbańczyk <[email protected]>
This PR should resolve #24 and #149 (I think).
This is also my first time coding anything in the CAD domain, so I'm open to criticism on the solution since I'm not very familiar with the domain. I have an intermediate level of knowledge of CAD as a hobby user, not as a programmer.
I'm also new to CadQuery, so the only potential issue I see is this only looks at the immediate parent workplane for a Face to use. I'm not sure if it should instead do some kind of recursive search through the entire stack for a Face (assuming there's a long stack of related workplanes)