Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRML export #482

Merged
merged 8 commits into from
Nov 19, 2020
Merged

VRML export #482

merged 8 commits into from
Nov 19, 2020

Conversation

adam-urbanczyk
Copy link
Member

Will resolve #476

@adam-urbanczyk adam-urbanczyk mentioned this pull request Oct 14, 2020
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #482 (17ad179) into master (3a50edd) will increase coverage by 0.75%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   93.64%   94.39%   +0.75%     
==========================================
  Files          30       30              
  Lines        5869     7906    +2037     
  Branches      625      972     +347     
==========================================
+ Hits         5496     7463    +1967     
- Misses        234      279      +45     
- Partials      139      164      +25     
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 92.48% <60.00%> (+1.54%) ⬆️
cadquery/occ_impl/exporters/__init__.py 93.06% <100.00%> (+0.36%) ⬆️
tests/test_exporters.py 100.00% <100.00%> (ø)
tests/test_cadquery.py 99.43% <0.00%> (+0.43%) ⬆️
cadquery/occ_impl/geom.py 89.50% <0.00%> (+0.56%) ⬆️
cadquery/cq.py 90.78% <0.00%> (+2.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a50edd...17ad179. Read the comment docs.

@adam-urbanczyk
Copy link
Member Author

Given the feedback in #476 I think it is ready for merging @jmwright .

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @adam-urbanczyk thanks! I'll merge here in a second.

@jmwright jmwright merged commit ec9cd46 into master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VRML Export
2 participants