More consistent handling of BoundaryBox tolerance #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 30 30
Lines 5880 5881 +1
Branches 626 626
=======================================
+ Hits 5507 5508 +1
Misses 234 234
Partials 139 139
Continue to review full report at Codecov.
|
|
Thanks for fixing this @marcus7070 +1 to merge after you've had a chance to take a look @adam-urbanczyk |
adam-urbanczyk
approved these changes
Oct 24, 2020
|
Thanks @marcus7070 , looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on some doc strings for another PR and noticed some inconsistencies in how the tolerances on bounding boxes were handled. This PR changes
BoundBox.addtolerance to default toTOL, just like theBoundBox._fromTopoDSmethod. AlsoShape.centerOfBoundBoxpreviously had another different default tolerance that wasn't propagated anyway.