Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded selector tests #541

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Conversation

marcus7070
Copy link
Member

The selector tests haven't been updated in a while, before I work on #517 I wanted to expand them a bit and help me catch any mistakes I make while refactoring some selectors.

I also removed that "polygon with rounded corners" test from testRadiusNthSelector, that's an edge case at best and not something we should be testing for.

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #541 (de2cef9) into master (a03648c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   94.11%   94.14%   +0.03%     
==========================================
  Files          29       29              
  Lines        6185     6204      +19     
  Branches      655      663       +8     
==========================================
+ Hits         5821     5841      +20     
  Misses        225      225              
+ Partials      139      138       -1     
Impacted Files Coverage Δ
tests/test_selectors.py 100.00% <100.00%> (ø)
cadquery/cq.py 89.45% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03648c...de2cef9. Read the comment docs.

@marcus7070
Copy link
Member Author

This is ready to review and/or merge.

@jmwright
Copy link
Member

@marcus7070 Thanks!

@jmwright jmwright merged commit 6a6e39f into CadQuery:master Dec 14, 2020
@marcus7070 marcus7070 deleted the selector-tests branch December 14, 2020 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants