Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutThruAll fix for non-planar faces #604

Merged
merged 2 commits into from
Jan 26, 2021
Merged

cutThruAll fix for non-planar faces #604

merged 2 commits into from
Jan 26, 2021

Conversation

adam-urbanczyk
Copy link
Member

This will resolve #355

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-urbanczyk I think it looks good.

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #604 (559e179) into master (8fcfb02) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   94.27%   94.22%   -0.05%     
==========================================
  Files          29       29              
  Lines        6353     6351       -2     
  Branches      676      675       -1     
==========================================
- Hits         5989     5984       -5     
- Misses        226      228       +2     
- Partials      138      139       +1     
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 91.92% <ø> (ø)
cadquery/cq.py 89.28% <100.00%> (-0.38%) ⬇️
tests/test_cadquery.py 99.04% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcfb02...559e179. Read the comment docs.

@adam-urbanczyk
Copy link
Member Author

Great, merging

@adam-urbanczyk adam-urbanczyk merged commit 3348c18 into master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cutThruAll failure
2 participants