Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wedge center #613

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Wedge center #613

merged 2 commits into from
Feb 1, 2021

Conversation

marcus7070
Copy link
Member

I should have read #611 more closely, I missed this as well. I've added a test for good measure.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #613 (be851aa) into master (2e8d674) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   93.84%   93.85%           
=======================================
  Files          31       31           
  Lines        6447     6457   +10     
  Branches      691      692    +1     
=======================================
+ Hits         6050     6060   +10     
  Misses        258      258           
  Partials      139      139           
Impacted Files Coverage Δ
cadquery/cq.py 89.38% <100.00%> (ø)
tests/test_cadquery.py 99.05% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8d674...be851aa. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcus7070

@jmwright jmwright merged commit e5e0fef into CadQuery:master Feb 1, 2021
@marcus7070 marcus7070 deleted the wedge-center branch February 2, 2021 01:05
@adam-urbanczyk
Copy link
Member

Thanks for the quick fix and the tests @marcus7070 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants