Centered option #617
Merged
Centered option #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 93.85% 93.93% +0.08%
==========================================
Files 31 31
Lines 6457 6526 +69
Branches 692 712 +20
==========================================
+ Hits 6060 6130 +70
Misses 258 258
+ Partials 139 138 -1
Continue to review full report at Codecov.
|
RubenRubens
reviewed
Feb 3, 2021
|
Fantastic work! |
jmwright
reviewed
Feb 4, 2021
jmwright
reviewed
Feb 4, 2021
jmwright
reviewed
Feb 4, 2021
|
@marcus7070 I re-ran one of the Azure CI checks. It had failed because it said it couldn't reach github.com. All the checks pass now. Let us know when it's ready for review. Thanks! |
Change all docstrings for centered options to be consistent and more clear
|
Ready for review now @jmwright. |
jmwright
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
Looks good. Thanks @marcus7070
I've requested a review from @adam-urbanczyk as well.
adam-urbanczyk
approved these changes
Feb 10, 2021
|
Thanks, looks good @marcus7070 ! |
just-georgeb
pushed a commit
to just-georgeb/cadquery
that referenced
this pull request
Feb 13, 2021
* Added 2d centered option to rect * Added single bool center option to box * Add single bool center option to sphere * Added single bool center option to wedge * Added 2d centered option to rarray * Black fix * Centered docstrings Change all docstrings for centered options to be consistent and more clear * Docstring fixes * Fix type hint on wedge method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve #567.
Also fixes some errors in the HTML docs for box and wedge.