Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify findSolid and findFace #662

Closed
wants to merge 2 commits into from

Conversation

RubenRubens
Copy link
Contributor

These are breaking changes. I believe they are worth considering thought. Few users would be affected and makes cq code much cleaner. For example, both Fx Bricks and Paramak have 0 references to findSolid.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #662 (ae13a84) into master (e4ed881) will increase coverage by 0.00%.
The diff coverage is 93.75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          31       31           
  Lines        6636     6637    +1     
  Branches      726      726           
=======================================
+ Hits         6240     6241    +1     
  Misses        258      258           
  Partials      138      138           
Impacted Files Coverage Δ
cadquery/cq.py 89.90% <93.75%> (+0.01%) ⬆️
cadquery/occ_impl/shapes.py 91.89% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ed881...ae13a84. Read the comment docs.

@marcus7070 marcus7070 self-requested a review February 24, 2021 22:47
@marcus7070
Copy link
Member

marcus7070 commented Feb 25, 2021

Ok, so you've simplified findSolid to two use cases:

  1. search stack and parents
  2. do not search stack but search parents

Instead of the string argument, can we just keep the searchStack bool argument and drop the searchParents?

I agree with the simplification, I've never used findSolid(searchParents=False), and if I ever needed to do that job I think I'd use a more general python technique like next(x for x in wp.vals() if isinstance(x, cq.Solid)).

I'm about to change the behaviour of findSolid in #662 #655 anyway, so good timing for this.

@RubenRubens
Copy link
Contributor Author

This might not be that interesting after all. So, don't waste time in here. I might consider reopening this PR soon with some interesting ideas. :)

@RubenRubens RubenRubens closed this Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants