Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start building CQ for py3.9 #672

Merged
merged 5 commits into from
Mar 16, 2021
Merged

Start building CQ for py3.9 #672

merged 5 commits into from
Mar 16, 2021

Conversation

adam-urbanczyk
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #672 (4025370) into master (dc9b0e7) will increase coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
+ Coverage   94.03%   94.77%   +0.74%     
==========================================
  Files          31       31              
  Lines        6642     9079    +2437     
  Branches      726     1132     +406     
==========================================
+ Hits         6246     8605    +2359     
- Misses        258      295      +37     
- Partials      138      179      +41     
Impacted Files Coverage Δ
tests/test_cadquery.py 99.36% <0.00%> (+0.23%) ⬆️
cadquery/occ_impl/shapes.py 93.34% <0.00%> (+1.41%) ⬆️
cadquery/cq.py 91.49% <0.00%> (+1.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc9b0e7...4025370. Read the comment docs.

@adam-urbanczyk adam-urbanczyk changed the title Try building for py3.9 Start building CQ for py3.9 Mar 14, 2021
@adam-urbanczyk
Copy link
Member Author

We might also want to stop providing 3.6 builds

@jmwright
Copy link
Member

@adam-urbanczyk What's the reasoning behind dropping support for Python 3.6?

@adam-urbanczyk
Copy link
Member Author

PEP 563 and shorter build times.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-urbanczyk The comment I made is just a suggestion. This PR looks good.

- template: conda-build.yml@templates
parameters:
name: Linux_39
vmImage: 'ubuntu-16.04'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16.04 is going EOL next month. GitHub Actions is going to start defaulting to 20.04 for the "latest" image when this EOL is hit. It might be worth moving to 18.04 for these builds while you're at it.

https://ubuntu.com/about/release-cycle

https://phoenixnap.com/kb/ubuntu-16-04-end-of-life

@adam-urbanczyk
Copy link
Member Author

OK, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants