Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cylinder 3D primitive to Workplane. #858

Merged
merged 6 commits into from
Sep 1, 2021
Merged

Added cylinder 3D primitive to Workplane. #858

merged 6 commits into from
Sep 1, 2021

Commits on Aug 25, 2021

  1. Added cylinder 3D primitive.

    @martinbudden
    martinbudden committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    4110dd0 View commit details
    Browse the repository at this point in the history

  2. Code reformat.

    @martinbudden
    martinbudden committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    2efa1f0 View commit details
    Browse the repository at this point in the history

  3. Changed to use Solid.makeCylinder.

    @martinbudden
    martinbudden committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    498f5d7 View commit details
    Browse the repository at this point in the history

  4. Swapped cylinder height and radius parameters to match cone.

    @martinbudden
    martinbudden committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    727ab27 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Update as per suggestions in review.

    @martinbudden
    martinbudden committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    71e3e40 View commit details
    Browse the repository at this point in the history

  2. Improved cylinder docstring.

    @martinbudden
    martinbudden committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    00083ed View commit details
    Browse the repository at this point in the history