Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perpendicular is not the same as not parallel #882

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

jdthorpe
Copy link
Contributor

@jdthorpe jdthorpe commented Sep 6, 2021

The current implementation of "#Z" is the same as "not |Z", which is not the same as perpendicular.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #882 (e38f9ee) into master (94030ad) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   95.88%   95.88%   -0.01%     
==========================================
  Files          32       32              
  Lines        7654     7652       -2     
  Branches      815      815              
==========================================
- Hits         7339     7337       -2     
  Misses        186      186              
  Partials      129      129              
Impacted Files Coverage Δ
cadquery/selectors.py 98.12% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94030ad...e38f9ee. Read the comment docs.

@adam-urbanczyk
Copy link
Member

Hm, the current implementation looks weird.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdthorpe

@adam-urbanczyk adam-urbanczyk merged commit a1df268 into CadQuery:master Oct 2, 2021
@adam-urbanczyk
Copy link
Member

Thanks for the patience and your contribution @jdthorpe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants