Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paramAt - handle trimmed curves (#686) #901

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

lorenzncode
Copy link
Member

paramAt - handle trimmed curves (#686)

Thanks to Roger for demonstrating another variation of the issue (Discord).

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #901 (7413044) into master (a1df268) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #901   +/-   ##
=======================================
  Coverage   95.91%   95.92%           
=======================================
  Files          32       32           
  Lines        7815     7825   +10     
  Branches      846      846           
=======================================
+ Hits         7496     7506   +10     
  Misses        186      186           
  Partials      133      133           
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 92.70% <100.00%> (ø)
tests/test_cadquery.py 99.24% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1df268...7413044. Read the comment docs.

@jmwright
Copy link
Member

The Windows tests are failing due to us needing to pin the version of libnetcdf to 4.7.4. @adam-urbanczyk does this need to be done in the OCP repo? The Azure config seems to only reference upstream packages and not the environment file in this repo if I understand correctly.

@adam-urbanczyk
Copy link
Member

Actually, It is still not resolved/under investigation. Sometimes conda chooses another build that does work.

@adam-urbanczyk
Copy link
Member

See #902

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lorenzncode

@jmwright jmwright merged commit 20097a9 into CadQuery:master Oct 20, 2021
@lorenzncode lorenzncode deleted the edge-positionAt branch November 1, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants