Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use Edge/Wire for sweep #919

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Allow to use Edge/Wire for sweep #919

merged 1 commit into from
Nov 15, 2021

Conversation

adam-urbanczyk
Copy link
Member

Will resolve #626

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #919 (a7461a7) into master (3581904) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a7461a7 differs from pull request most recent head 633dc86. Consider uploading reports for the commit 633dc86 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
+ Coverage   95.94%   95.96%   +0.01%     
==========================================
  Files          32       32              
  Lines        7827     7853      +26     
  Branches      846      848       +2     
==========================================
+ Hits         7510     7536      +26     
  Misses        184      184              
  Partials      133      133              
Impacted Files Coverage Δ
cadquery/cq.py 91.54% <100.00%> (+0.04%) ⬆️
tests/test_cadquery.py 99.25% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3581904...633dc86. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk

Looks good

@marcus7070 marcus7070 merged commit 8d1381b into master Nov 15, 2021
@marcus7070
Copy link
Member

Thanks @adam-urbanczyk!

@marcus7070 marcus7070 deleted the sweep-shape branch November 15, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow cq.Shape as sweep path
3 participants