Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve edge rendering quality in the docs #920

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Improve edge rendering quality in the docs #920

merged 3 commits into from
Nov 17, 2021

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Nov 16, 2021

PR meant to improve edge rendering quality in the docs.

NB: only js files/code changed.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #920 (8a07478) into master (8d1381b) will not change coverage.
The diff coverage is n/a.

❗ Current head 8a07478 differs from pull request most recent head 08228df. Consider uploading reports for the commit 08228df to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #920   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          39       39           
  Lines        9130     9130           
  Branches     1017     1017           
=======================================
  Hits         8775     8775           
  Misses        206      206           
  Partials      149      149           
Impacted Files Coverage Δ
cadquery/occ_impl/jupyter_tools.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1381b...08228df. Read the comment docs.

@marcus7070
Copy link
Member

Very nice, thanks @adam-urbanczyk.

Previous:
screenshot2021-11-17-203254

After this PR:
screenshot2021-11-17-203245

What was the change to vtk.js? I can't tell from just the commit/diff. We should add that information to the commit message when merging.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk !

@jmwright jmwright merged commit cd0c81e into master Nov 17, 2021
@adam-urbanczyk
Copy link
Member Author

adam-urbanczyk commented Nov 18, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants