Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight improvement of the sketch tutorial #921

Merged
merged 4 commits into from
Nov 19, 2021
Merged

Slight improvement of the sketch tutorial #921

merged 4 commits into from
Nov 19, 2021

Conversation

adam-urbanczyk
Copy link
Member

Mention modes explicitly

@adam-urbanczyk
Copy link
Member Author

@Jojain what do you think? Is it clear(er)?

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #921 (042bb09) into master (cd0c81e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 042bb09 differs from pull request most recent head e7bc699. Consider uploading reports for the commit e7bc699 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #921   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          39       39           
  Lines        9130     9130           
  Branches     1017     1017           
=======================================
  Hits         8775     8775           
  Misses        206      206           
  Partials      149      149           
Impacted Files Coverage Δ
cadquery/cq.py 91.76% <ø> (ø)
cadquery/sketch.py 97.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0c81e...e7bc699. Read the comment docs.

doc/sketch.rst Outdated Show resolved Hide resolved
@Jojain
Copy link
Contributor

Jojain commented Nov 18, 2021

Thanks @adam-urbanczyk this is much more clear now !

doc/sketch.rst Outdated Show resolved Hide resolved
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @adam-urbanczyk

I made one extremely minor suggestion. It sounds like @Jojain approves, so can we merge?

Co-authored-by: Jeremy Wright <[email protected]>
@jmwright
Copy link
Member

I think this looks good. Can I merge it @adam-urbanczyk ?

@adam-urbanczyk
Copy link
Member Author

+1

@jmwright jmwright merged commit d6c41d7 into master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants