Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch ArcAngle constraint fix #932

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

lorenzncode
Copy link
Member

  • Update cost function

- Update cost function
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #932 (e703925) into master (84edaf5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files          39       39           
  Lines        9162     9162           
  Branches     1107     1107           
=======================================
  Hits         8801     8801           
  Misses        209      209           
  Partials      152      152           
Impacted Files Coverage Δ
cadquery/occ_impl/sketch_solver.py 91.14% <100.00%> (ø)
tests/test_sketch.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84edaf5...e703925. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lorenzncode !

@jmwright jmwright merged commit 6b01d78 into CadQuery:master Dec 21, 2021
@lorenzncode lorenzncode deleted the sketch-arcangle branch December 21, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants