Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge tags on boolean ops #934

Merged
merged 4 commits into from
Dec 24, 2021
Merged

Merge tags on boolean ops #934

merged 4 commits into from
Dec 24, 2021

Conversation

lorenzncode
Copy link
Member

This is to address #888. Of course, let me know if any other changes are required. Thanks!

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #934 (d8eb5b6) into master (6b01d78) will increase coverage by 0.00%.
The diff coverage is 97.91%.

❗ Current head d8eb5b6 differs from pull request most recent head ef8b320. Consider uploading reports for the commit ef8b320 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #934   +/-   ##
=======================================
  Coverage   96.05%   96.06%           
=======================================
  Files          39       39           
  Lines        9162     9204   +42     
  Branches     1107     1109    +2     
=======================================
+ Hits         8801     8842   +41     
  Misses        209      209           
- Partials      152      153    +1     
Impacted Files Coverage Δ
cadquery/cq.py 91.74% <92.85%> (-0.02%) ⬇️
tests/test_cadquery.py 99.27% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b01d78...ef8b320. Read the comment docs.

@adam-urbanczyk adam-urbanczyk linked an issue Dec 22, 2021 that may be closed by this pull request
Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lorenzncode

@jmwright jmwright merged commit 9ceea9c into CadQuery:master Dec 24, 2021
@lorenzncode lorenzncode deleted the tags-merge branch December 24, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bool ops/ add should merge tags on the Workplane level
3 participants