Allow to disable rules compressor #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coorasse
force-pushed
the
disable_rules_compressor
branch
from
3f025c5
to
cfccd81
Compare
coorasse
force-pushed
the
disable_rules_compressor
branch
from
cfccd81
to
a8f75fe
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some corner cases where the rules compressor does not play well with STI.
Since the rules compressor might not be needed in such cases, we want to allow disabling it.
We can now disable it globally or per-query.
This PR fixes #783 and #663.
I believe such cases can be resolved by disabling the rules compressor.
If, in the future, a case arises where both STI and rules compressor are needed, I'll gladly accept a PR. 😄