Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress duplicates rules #843

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

MrChoclate
Copy link
Contributor

Hello 👋

In my current project, some rules are duplicated and applied several times. It creates big SQL queries that are hard to read. With this PR, the duplicated rules are removed and the SQL query is equivalent and simpler.

We also have some performance gain on some specific queries.

Let me know if I need to do anything else to get this PR merged 🙏

Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR. Thanks!

@coorasse coorasse merged commit 2f4c3cf into CanCanCommunity:develop May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants