[EOSF-594] Add example controller unit tests and component integration tests

bower.json

@@ -12,7 +12,8 @@
  "toastr": "^2.1.2",
  "hint.css": "^2.3.2",
  "jquery.tagsinput": "^1.3.6",
- "loaders.css": "^0.1.2"
+ "loaders.css": "^0.1.2",
+ "jquery-mockjax": "~2.2.1"
  },
  "resolutions": {
  "jquery": "~2.2.4"

package.json

@@ -56,7 +56,9 @@
  "ember-collection": "1.0.0-alpha.6",
  "ember-cp-validations": "^2.9.4",
  "ember-data": "^2.7.0",
+ "ember-data-factory-guy": "^2.11.6",
  "ember-export-application-global": "^1.0.5",
+ "ember-faker": "^1.1.1",
  "ember-font-awesome": "2.1.1",
  "ember-get-config": "0.0.4",
  "ember-i18n": "4.3.1",

tests/acceptance/content-test.js

@@ -0,0 +1,19 @@
+import { test } from 'qunit';
+import moduleForAcceptance from 'preprint-service/tests/helpers/module-for-acceptance';
+// import FactoryGuy from 'ember-data-factory-guy';
+
+moduleForAcceptance('Acceptance | content');
+
+test('visiting /content', function(assert) {
+ // TODO: Problems getting preprint content page. url = '/' completely breaks testem
+ let container = this.application.__container__;
+ // let preprint = FactoryGuy.make('preprint');
+ // let url = '/' + preprint.get('id');
+ // url = '/'
+ // visit(url);
+
+ andThen(() => {
+ assert.ok(container);
+ // assert.equal(currentURL(), url);
+ });
+});

tests/acceptance/discover-test.js

@@ -0,0 +1,29 @@
+import { test } from 'qunit';
+import moduleForAcceptance from 'preprint-service/tests/helpers/module-for-acceptance';
+
+moduleForAcceptance('Acceptance | discover');
+
+test('visiting /discover', function(assert) {
+ visit('preprints/discover');
+ andThen(() => assert.equal(currentURL(), '/preprints/discover?provider=&subject='));
+});
+
+test('visit discover with queryParams', function(assert) {
+ let container = this.application.__container__;
+
+ visit('preprints/discover?provider=OSF&subject=Business');
+
+ andThen(() => {
+ let controller = container.lookup('controller:discover');
+ let providers = controller.activeFilters.providers;
+ let subjects = controller.activeFilters.subjects;
+
+ assert.ok(providers.indexOf('OSF') !== -1);
+ assert.equal(providers.length, 1);
+
+ assert.ok(subjects.indexOf('Business') !== -1);
+ assert.equal(subjects.length, 1);
+
+ assert.equal(currentURL(), 'preprints/discover?provider=OSF&subject=Business');
+ });
+});

tests/helpers/module-for-acceptance.js

@@ -2,22 +2,24 @@ import { module } from 'qunit';
 import Ember from 'ember';
 import startApp from '../helpers/start-app';
 import destroyApp from '../helpers/destroy-app';
+import { manualSetup } from 'ember-data-factory-guy';
 
 const { RSVP: { Promise } } = Ember;
 
 export default function(name, options = {}) {
  module(name, {
  beforeEach() {
- this.application = startApp();
+ this.application = startApp();
+ manualSetup(this.application.__container__);
 
- if (options.beforeEach) {
- return options.beforeEach.apply(this, arguments);
- }
+  if (options.beforeEach) {
+  return options.beforeEach.apply(this, arguments);
+  }
  },
-
  afterEach() {
- let afterEach = options.afterEach && options.afterEach.apply(this, arguments);
- return Promise.resolve(afterEach).then(() => destroyApp(this.application));
+ // FakeServer.stop();
+ let afterEach = options.afterEach && options.afterEach.apply(this, arguments);
+ return Promise.resolve(afterEach).then(() => destroyApp(this.application));
  }
  });
 }

tests/integration/components/author-link-test.js

@@ -0,0 +1,33 @@
+import Ember from 'ember';
+import { moduleForComponent, test } from 'ember-qunit';
+import hbs from 'htmlbars-inline-precompile';
+import FactoryGuy, { manualSetup } from 'ember-data-factory-guy';
+
+moduleForComponent('author-link', 'Integration | Component | author link', {
+ integration: true
+});
+
+test('renders links and non-links', function(assert) {
+
+ // Set any properties with this.set('myProperty', 'value');
+ // Handle any actions with this.on('myAction', function(val) { ... });
+ manualSetup(this.container);
+ let contributorModel = FactoryGuy.make('contributor');
+ // Problem here is that author link expects a share search-result contributor,
+ // not a store instance of a contributor and its user(s).
+ let contributor = {users: {identifiers: []}};
+ contributor.users.name = contributorModel.get('users.fullName');
+ contributor = Ember.merge(contributor, contributorModel.serialize().data.attributes);
+ this.set('contributor', contributor);
+
+ this.render(hbs`{{author-link contributor=contributor}}`);
+ assert.ok(!this.$().has('a').length);
+ assert.equal(this.$().text().trim(), contributorModel.get('users.fullName'));
+
+ contributor.users.identifiers.push('https://staging.osf.io/cool');
+ this.set('contributor', contributor);
+
+ this.render(hbs`{{author-link contributor=contributor}}`);
+ assert.ok(this.$().has('a').length);
+ assert.equal(this.$().text().trim(), contributorModel.get('users.fullName'));
+});

tests/integration/components/subject-picker-test.js

@@ -0,0 +1,16 @@
+import { moduleForComponent, test } from 'ember-qunit';
+import hbs from 'htmlbars-inline-precompile';
+
+moduleForComponent('subject-picker', 'Integration | Component | subject picker', {
+ integration: true
+});
+
+test('it renders', function(assert) {
+
+ //TODO: looks like author-link tests
+
+ this.render(hbs`{{subject-picker}}`);
+
+ assert.equal(this.$().text().trim(), '');
+
+});

tests/unit/controllers/content-test.js

@@ -1,12 +1,107 @@
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
+import FactoryGuy, { manualSetup } from 'ember-data-factory-guy';
+
 
 moduleFor('controller:content', 'Unit | Controller | content', {
- // Specify the other units that are required for this test.
- needs: ['service:metrics', 'service:theme']
+ needs: ['service:metrics', 'service:theme', 'model:file', 'model:preprint',
+ 'model:preprint-provider', 'model:node', 'model:license',
+ 'model:user', 'model:citation', 'model:draft-registration',
+ 'model:contributor', 'model:comment', 'model:institution',
+ 'model:registration', 'model:file-provider', 'model:log',
+ 'model:node-link', 'model:wiki'],
+ beforeEach: function() {
+ manualSetup(this.container);
+ }
 });
 
 // Replace this with your real tests.
 test('it exists', function(assert) {
- let controller = this.subject();
- assert.ok(controller);
+ let controller = this.subject();
+ assert.ok(controller);
+});
+
+test('fullLicenseText computed property', function(assert) {
+ let ctrl = this.subject();
+ let preprint = FactoryGuy.make('preprint');
+ let license = preprint.get('license');
+ ctrl.set('model', preprint);
+ license.set('text', 'On {{year}}, for {{copyrightHolders}}');
+
+ preprint.set('licenseRecord', {
+ year: '2001',
+ copyright_holders: ['Henrique', 'Someone Else']
+ });
+ ctrl.notifyPropertyChange('model.license');
+ assert.equal(ctrl.get('fullLicenseText'), 'On 2001, for Henrique,Someone Else');
+
+ preprint.set('licenseRecord', {
+ year: '',
+ copyright_holders: []
+ });
+ ctrl.notifyPropertyChange('model.license');
+ assert.equal(ctrl.get('fullLicenseText'), 'On , for ');
+
+ preprint.set('licenseRecord', {
+ year: '{{year}}',
+ copyright_holders: ['{{copyrightHolders}}']
+ });
+ ctrl.notifyPropertyChange('model.license');
+ assert.equal(ctrl.get('fullLicenseText'), 'On {{year}}, for {{copyrightHolders}}');
+});
+
+test('useShortenedDescription computed property', function(assert) {
+ let ctrl = this.subject();
+ let node = FactoryGuy.make('node');
+ ctrl.set('node', node);
+ Ember.run(() => {
+ node.set('description', 'string'.repeat(100).slice(0, 351));
+ ctrl.notifyPropertyChange('node.description');
+ assert.ok(ctrl.get('useShortenedDescription'));
+
+ node.set('description', 'string'.repeat(100).slice(0, 350));
+ ctrl.notifyPropertyChange('node.description');
+ assert.ok(!ctrl.get('useShortenedDescription'));
+
+ node.set('description', 'string'.repeat(100).slice(0, 349));
+ ctrl.notifyPropertyChange('node.description');
+ assert.ok(!ctrl.get('useShortenedDescription'));
+ });
+});
+
+test('description computed property', function(assert) {
+ Ember.run(() => {
+ let ctrl = this.subject();
+ let node = FactoryGuy.make('node');
+ ctrl.set('node', node);
+ ctrl.set('expandedAbstract', false);
+
+ //Test cut at 350 characters
+ let description = 'string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string str';
+ let notExpanded = description.slice(0, 350) + '...';
+ node.set('description', description);
+ ctrl.notifyPropertyChange('description');
+ assert.equal(ctrl.get('description'), notExpanded);
+
+ //Test cut at less than 350 characters to not cut in middle of word
+ description = 'string stringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstring';
+ notExpanded = 'string ...';
+ node.set('description', description);
+ ctrl.notifyPropertyChange('description');
+ assert.equal(ctrl.get('description'), notExpanded);
+
+ //Test less than 350 doesn't use description (uses node.description)
+
+ ctrl.set('expandedAbstract', true);
+
+ description = 'string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string string str';
+ node.set('description', description);
+ ctrl.notifyPropertyChange('description');
+ assert.equal(ctrl.get('description'), description);
+
+ description = 'string stringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstringstring';
+ node.set('description', description);
+ ctrl.notifyPropertyChange('description');
+ assert.equal(ctrl.get('description'), description);
+ });
 });

yarn.lock

@@ -2058,6 +2058,13 @@ ember-cp-validations@^2.9.4:
  exists-sync "0.0.3"
  walk-sync "^0.2.0"
 
+ember-data-factory-guy@^2.11.6:
+ version "2.11.6"
+ resolved "https://registry.yarnpkg.com/ember-data-factory-guy/-/ember-data-factory-guy-2.11.6.tgz#c4b2170f90ee7c3897c162f1fc5579a7e287919d"
+ dependencies:
+ broccoli-funnel "^1.0.1"
+ broccoli-merge-trees "^1.1.1"
+
 [email protected]:
  version "0.1.7"
  resolved "https://registry.yarnpkg.com/ember-data-has-many-query/-/ember-data-has-many-query-0.1.7.tgz#f34cb7a3abf25c94a6265e2d072f3844e8f23c4d"
@@ -2098,6 +2105,10 @@ ember-export-application-global@^1.0.5:
  dependencies:
  ember-cli-babel "^5.1.10"
 
+ember-faker@^1.1.1:
+ version "1.1.1"
+ resolved "https://registry.yarnpkg.com/ember-faker/-/ember-faker-1.1.1.tgz#90ca83edef385d8f43bed3ceaed263b59f68773c"
+
 ember-factory-for-polyfill@^1.1.0:
  version "1.1.1"
  resolved "https://registry.yarnpkg.com/ember-factory-for-polyfill/-/ember-factory-for-polyfill-1.1.1.tgz#c1124d541a058baaa6681d9611340c16f0baf660"