Rollup merge of rust-lang#64078 - Mark-Simulacrum:compiletest-lint-un…

…used, r=petrochenkov

compiletest: disable -Aunused for run-pass tests

Disabled the flag, but that led to quite a bit of fall out -- I think most of it is benign but I've not investigated thoroughly.

r? @petrochenkov

src/test/ui/associated-type-bounds/bounds-on-assoc-in-trait.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 #![feature(associated_type_bounds)]
 

src/test/ui/associated-type-bounds/fn-apit.rs

@@ -1,6 +1,7 @@
 // run-pass
 // aux-build:fn-aux.rs
 
+#![allow(unused)]
 #![feature(associated_type_bounds)]
 
 extern crate fn_aux;

src/test/ui/associated-type-bounds/fn-dyn-apit.rs

@@ -1,6 +1,7 @@
 // run-pass
 // aux-build:fn-dyn-aux.rs
 
+#![allow(unused)]
 #![feature(associated_type_bounds)]
 
 extern crate fn_dyn_aux;

src/test/ui/associated-type-bounds/fn-inline.rs

@@ -1,6 +1,7 @@
 // run-pass
 // aux-build:fn-aux.rs
 
+#![allow(unused)]
 #![feature(associated_type_bounds)]
 
 extern crate fn_aux;

src/test/ui/associated-type-bounds/fn-where.rs

@@ -1,6 +1,7 @@
 // run-pass
 // aux-build:fn-aux.rs
 
+#![allow(unused)]
 #![feature(associated_type_bounds)]
 
 extern crate fn_aux;

src/test/ui/associated-type-bounds/fn-wrap-apit.rs

@@ -2,6 +2,7 @@
 // aux-build:fn-aux.rs
 
 #![feature(associated_type_bounds)]
+#![allow(dead_code)]
 
 extern crate fn_aux;
 

src/test/ui/associated-type-bounds/struct-bounds.rs

@@ -1,5 +1,6 @@
 // run-pass
 
+#![allow(unused)]
 #![feature(associated_type_bounds)]
 
 trait Tr1 { type As1; }

src/test/ui/async-await/argument-patterns.rs

@@ -1,7 +1,6 @@
 // edition:2018
-// run-pass
+// check-pass
 
-#![allow(unused_variables)]
 #![deny(unused_mut)]
 
 type A = Vec<u32>;

src/test/ui/async-await/async-await.rs

@@ -1,5 +1,7 @@
 // run-pass
 
+#![allow(unused)]
+
 // edition:2018
 // aux-build:arc_wake.rs
 

src/test/ui/async-await/drop-order/drop-order-for-locals-when-cancelled.rs

@@ -3,14 +3,16 @@
 // run-pass
 
 #![deny(dead_code)]
+#![allow(unused_variables)]
+#![allow(unused_must_use)]
+#![allow(path_statements)]
 
 // Test that the drop order for locals in a fn and async fn matches up.
 extern crate arc_wake;
 
 use arc_wake::ArcWake;
 use std::cell::RefCell;
 use std::future::Future;
-use std::marker::PhantomData;
 use std::pin::Pin;
 use std::rc::Rc;
 use std::sync::Arc;
@@ -42,7 +44,7 @@ struct NeverReady;
 
 impl Future for NeverReady {
  type Output = ();
- fn poll(mut self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {
+ fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {
  Poll::Pending
  }
 }

src/test/ui/async-await/drop-order/drop-order-when-cancelled.rs

@@ -6,6 +6,8 @@
 // parameters (used or unused) are not dropped until the async fn is cancelled.
 // This file is mostly copy-pasted from drop-order-for-async-fn-parameters.rs
 
+#![allow(unused_variables)]
+
 extern crate arc_wake;
 
 use arc_wake::ArcWake;
@@ -43,7 +45,7 @@ struct NeverReady;
 
 impl Future for NeverReady {
  type Output = ();
- fn poll(mut self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {
+ fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {
  Poll::Pending
  }
 }

src/test/ui/async-await/issues/issue-54752-async-block.stderr

@@ -0,0 +1,8 @@
+warning: unnecessary parentheses around assigned value
+ --> $DIR/issue-54752-async-block.rs:6:22
+ |
+LL | fn main() { let _a = (async { }); }
+ | ^^^^^^^^^^^^ help: remove these parentheses
+ |
+ = note: `#[warn(unused_parens)]` on by default
+

src/test/ui/async-await/issues/issue-59972.rs

@@ -4,7 +4,7 @@
 
 // run-pass
 
-// compile-flags: --edition=2018
+// compile-flags: --edition=2018 -Aunused
 
 pub enum Uninhabited { }
 

src/test/ui/async-await/multiple-lifetimes/hrtb.rs

@@ -1,5 +1,5 @@
 // edition:2018
-// run-pass
+// check-pass
 
 // Test that we can use async fns with multiple arbitrary lifetimes.
 

src/test/ui/borrowck/borrowck-migrate-to-nll.rs

@@ -17,7 +17,7 @@
 // revisions: zflag edition
 //[zflag]compile-flags: -Z borrowck=migrate
 //[edition]edition:2018
-//[zflag] run-pass
+//[zflag] check-pass
 
 pub struct Block<'a> {
  current: &'a u8,

src/test/ui/borrowck/issue-10876.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 enum Nat {
  S(Box<Nat>),

src/test/ui/borrowck/two-phase-multiple-activations.rs

@@ -11,13 +11,13 @@ pub trait FakeRead {
 }
 
 impl FakeRead for Foo {
- fn read_to_end(&mut self, buf: &mut Vec<u8>) -> Result<usize> {
+ fn read_to_end(&mut self, _buf: &mut Vec<u8>) -> Result<usize> {
  Ok(4)
  }
 }
 
 fn main() {
  let mut a = Foo {};
  let mut v = Vec::new();
- a.read_to_end(&mut v);
+ a.read_to_end(&mut v).unwrap();
 }

src/test/ui/const-generics/apit-with-const-param.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 #![feature(const_generics)]
 //~^ WARN the feature `const_generics` is incomplete and may cause the compiler to crash

src/test/ui/const-generics/array-wrapper-struct-ctor.rs

@@ -3,6 +3,8 @@
 #![feature(const_generics)]
 //~^ WARN the feature `const_generics` is incomplete and may cause the compiler to crash
 
+#![allow(dead_code)]
+
 struct ArrayStruct<T, const N: usize> {
  data: [T; N],
 }

src/test/ui/const-generics/const-types.rs

@@ -3,7 +3,7 @@
 #![feature(const_generics)]
 //~^ WARN the feature `const_generics` is incomplete and may cause the compiler to crash
 
-#[allow(dead_code)]
+#![allow(dead_code, unused_variables)]
 
 struct ConstArray<T, const LEN: usize> {
  array: [T; LEN],

src/test/ui/const-generics/issue-61422.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 #![feature(const_generics)]
 //~^ WARN the feature `const_generics` is incomplete and may cause the compiler to crash
@@ -8,7 +8,7 @@ use std::mem;
 fn foo<const SIZE: usize>() {
  let arr: [u8; SIZE] = unsafe {
  #[allow(deprecated)]
- let mut array: [u8; SIZE] = mem::uninitialized();
+ let array: [u8; SIZE] = mem::uninitialized();
  array
  };
 }

src/test/ui/const-generics/unused-const-param.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 #![feature(const_generics)]
 //~^ WARN the feature `const_generics` is incomplete and may cause the compiler to crash

src/test/ui/consts/const-eval/const_transmute.rs

@@ -1,6 +1,7 @@
 // run-pass
 
 #![feature(const_fn_union)]
+#![allow(dead_code)]
 
 #[repr(C)]
 union Transmute<T: Copy, U: Copy> {

src/test/ui/consts/const-labeled-break.rs

@@ -1,4 +1,4 @@
-// run-pass
+// build-pass
 
 // Using labeled break in a while loop has caused an illegal instruction being
 // generated, and an ICE later.

src/test/ui/consts/packed_pattern.stderr

@@ -0,0 +1,8 @@
+warning: unreachable pattern
+ --> $DIR/packed_pattern.rs:16:9
+ |
+LL | FOO => unreachable!(),
+ | ^^^
+ |
+ = note: `#[warn(unreachable_patterns)]` on by default
+

src/test/ui/consts/packed_pattern2.stderr

@@ -0,0 +1,8 @@
+warning: unreachable pattern
+ --> $DIR/packed_pattern2.rs:24:9
+ |
+LL | FOO => unreachable!(),
+ | ^^^
+ |
+ = note: `#[warn(unreachable_patterns)]` on by default
+

src/test/ui/deprecation/deprecation-in-future.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 #![deny(deprecated_in_future)]
 

src/test/ui/drop/dynamic-drop-async.rs

@@ -8,6 +8,7 @@
 // ignore-wasm32-bare compiled with panic=abort by default
 
 #![feature(slice_patterns)]
+#![allow(unused)]
 
 use std::{
  cell::{Cell, RefCell},

src/test/ui/hrtb/issue-57639.rs

@@ -10,7 +10,7 @@
 //
 // See [this comment on GitHub][c] for more details.
 //
-// run-pass
+// check-pass
 //
 // [c]: https:/rust-lang/rust/issues/57639#issuecomment-455685861
 

src/test/ui/if-ret.stderr

@@ -0,0 +1,8 @@
+warning: unreachable block in `if` expression
+ --> $DIR/if-ret.rs:6:24
+ |
+LL | fn foo() { if (return) { } }
+ | ^^^
+ |
+ = note: `#[warn(unreachable_code)]` on by default
+

src/test/ui/impl-trait/closure-calling-parent-fn.rs

@@ -5,7 +5,7 @@
 // `foo` and hence is treated opaquely within the closure body. This
 // resulted in a failed subtype relationship.
 //
-// run-pass
+// check-pass
 
 fn foo() -> impl Copy { || foo(); }
 fn bar() -> impl Copy { || bar(); }

src/test/ui/impl-trait/issues/issue-53457.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 #![feature(type_alias_impl_trait)]
 
@@ -9,7 +9,7 @@ fn bar<F: Fn(&i32) + Clone>(f: F) -> F {
 }
 
 fn foo() -> X {
- bar(|x| ())
+ bar(|_| ())
 }
 
 fn main() {}

src/test/ui/impl-trait/multiple-lifetimes/inverse-bounds.rs

@@ -1,5 +1,5 @@
 // edition:2018
-// run-pass
+// check-pass
 // revisions: migrate mir
 //[mir]compile-flags: -Z borrowck=mir
 

src/test/ui/impl-trait/needs_least_region_or_bound.rs

@@ -1,9 +1,7 @@
-// run-pass
+// check-pass
 
 #![feature(member_constraints)]
 
-use std::fmt::Debug;
-
 trait MultiRegionTrait<'a, 'b> {}
 impl<'a, 'b> MultiRegionTrait<'a, 'b> for (&'a u32, &'b u32) {}
 

src/test/ui/issues/issue-26448-2.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 pub struct Bar<T> {
  items: Vec<&'static str>,

src/test/ui/issues/issue-26448-3.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 pub struct Item {
  _inner: &'static str,

src/test/ui/issues/issue-27697.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 use std::ops::Deref;
 

src/test/ui/issues/issue-38591.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 struct S<T> {
  t : T,

src/test/ui/issues/issue-43806.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 #![deny(unused_results)]
 

src/test/ui/issues/issue-48132.rs

@@ -3,6 +3,8 @@
 
 // run-pass
 
+#![allow(dead_code)]
+
 struct Inner<I, V> {
  iterator: I,
  item: V,

src/test/ui/issues/issue-48179.rs

@@ -1,7 +1,7 @@
 // Regression test for #48132. This was failing due to problems around
 // the projection caching and dropck type enumeration.
 
-// run-pass
+// check-pass
 
 pub struct Container<T: Iterator> {
  value: Option<T::Item>,

src/test/ui/issues/issue-61711-once-caused-rustc-inf-loop.rs

@@ -5,7 +5,7 @@
 // aux-build:xcrate-issue-61711-b.rs
 // compile-flags:--extern xcrate_issue_61711_b
 
-// run-pass
+// build-pass
 
 fn f<F: Fn(xcrate_issue_61711_b::Struct)>(_: F) { }
 fn main() { }

src/test/ui/lint/empty-lint-attributes.rs

@@ -1,6 +1,6 @@
 #![feature(lint_reasons)]
 
-// run-pass
+// check-pass
 
 // Empty (and reason-only) lint attributes are legal—although we may want to
 // lint them in the future (Issue #55112).

src/test/ui/nll/issue-55288.rs

@@ -1,4 +1,4 @@
-// run-pass
+// check-pass
 
 struct Slice(&'static [&'static [u8]]);