Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of models leads to high GC usage #3125

Open
pjcozzi opened this issue Oct 24, 2015 · 5 comments
Open

Lots of models leads to high GC usage #3125

pjcozzi opened this issue Oct 24, 2015 · 5 comments
Labels
category - memory/performance category - model onramping priority - high type - enhancement

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 24, 2015

As discussed here: #3059 (comment)

This could be true for all primitives (meaning the issue is in Scene.render, not Model.update). @lilleyse is looking into it.
@pjcozzi pjcozzi mentioned this issue Oct 24, 2015
Merged
@pjcozzi
Copy link
Contributor Author

pjcozzi commented Oct 26, 2015

@lilleyse any update here?

@lilleyse
Copy link
Contributor

Not yet, I'll be able to look into it soon.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Oct 28, 2015

@bagnell may have fixed this (similar to #3131 (comment)).

@lilleyse please verify.

@lilleyse
Copy link
Contributor

I didn't see a difference. However, I've noticed that updateCommands is the cause of the problems when instancing is disabled. https:/AnalyticalGraphicsInc/cesium/blob/3d-tiles/Source/Scene/ModelInstanceCollection.js#L703-L735.

As far as I can tell, there are no allocations. Maybe someone else can verify that?

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Oct 28, 2015

Nothing jumps out at me. Did you step through the function and all the functions it calls? Are the array indices sane?

@pjcozzi pjcozzi mentioned this issue Jun 14, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - memory/performance category - model onramping priority - high type - enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pjcozzi @lilleyse @ggetz @j9liu