Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Tiles - TileOrientedBoundingBox debug volume should be 2x2x2 #4581

Closed
sdgrimm opened this issue Nov 2, 2016 · 2 comments
Closed

3D Tiles - TileOrientedBoundingBox debug volume should be 2x2x2 #4581

sdgrimm opened this issue Nov 2, 2016 · 2 comments
Labels
good first issue An opportunity for first time contributors type - bug

Comments

@sdgrimm
Copy link

sdgrimm commented Nov 2, 2016

I am using OrientedBoundingBox to create 3D Tiles point cloud tilesets with oriented bounding box volumes. It works perfectly. However, when Cesium3DTileset#debugShowBoundingVolume is enabled, the BoxOutlineGeometry is incorrect. The cube being created is 1x1x1, but I believe it should be 2x2x2 to match OrientedBoundingBox. See (https:/AnalyticalGraphicsInc/cesium/blob/3d-tiles/Source/Scene/TileOrientedBoundingBox.js#L123).

@pjcozzi pjcozzi added type - bug good first issue An opportunity for first time contributors labels Nov 2, 2016
@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 2, 2016

Thanks for the report, @sdgrimm. I added this issue to the roadmap, #3241.

A pull request into the 3d-tiles branch with a fix is also very welcome. See Getting Started Contributing if you have time to investigate.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 10, 2017

Thanks again for the report, @sdgrimm! This was fixed in #4845 and is now in the 3D Tiles branch.

@pjcozzi pjcozzi closed this as completed Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An opportunity for first time contributors type - bug
Projects
None yet
Development

No branches or pull requests

2 participants