Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache pickPosition #5117

Closed
lilleyse opened this issue Mar 17, 2017 · 0 comments · Fixed by #5169
Closed

Cache pickPosition #5117

lilleyse opened this issue Mar 17, 2017 · 0 comments · Fixed by #5169
Labels
onramping type - enhancement

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Mar 17, 2017 •
edited
Loading

Orthographic projection calls pickPosition to determine the correct frustum width. ScreenSpaceCameraController also calls it in pickGlobe. Additionally app code may be calling it multiple times per frame. Since this is an expensive operations that causes a CPU/GPU sync, it may be good to cache the pickPosition results per frame, or over multiple frames.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
onramping type - enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache pickposition
2 participants
@pjcozzi @lilleyse