Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basePath option to Cesium.Model.fromGltf #5320

Closed
HowardWolosky opened this issue May 12, 2017 · 2 comments
Closed

Add basePath option to Cesium.Model.fromGltf #5320

HowardWolosky opened this issue May 12, 2017 · 2 comments
Labels
good first issue An opportunity for first time contributors type - enhancement

Comments

@HowardWolosky
Copy link

Right now, there are two ways of loading glTF content:

Cesium.Model.fromGltf and new Cesium.Model. When using new Cesium.Model, you can specify a basePath (although it doesn't currently work (see Issue #5319)). Unfortunately, you can't specify a basePath when using Cesium.Model.fromGltf. This means it's not possible to use that API to load local files that leverage relative paths for their binary content.

This is to track the request to add the ability to specify a basePath for fromGltf as well.
@pjcozzi
Copy link
Contributor

pjcozzi commented May 17, 2017

This should be a small tweak.

@rahwang do you want to make this change? @lilleyse can advise. Just be careful that this probably needs to be part of the key for the cache.

@pjcozzi pjcozzi added good first issue An opportunity for first time contributors type - enhancement labels May 17, 2017
@moneimne moneimne mentioned this issue Jun 1, 2017
Merged
@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 2, 2017

Thanks again for the input, @HowardWolosky.

Added in #5403 by @moneimne

@pjcozzi pjcozzi closed this as completed Jun 2, 2017
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this issue Jun 2, 2017
@HowardWolosky
Update the Cesium and Babylon engines / Make Babylon work on unsaved …
5ef5e60 
…changes

* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).
* Babylon (like Cesium) now defaults to previewing the content in the tab as opposed to the content saved in the file, the same way it's done in this [Babylon Plaground Example](https://www.babylonjs-playground.com/#1AbIIF#7).

Resolves Issue AnalyticalGraphicsInc#15

> **Work in Progress**
> - This doesn't have a Babylon with pull 2222 since that hasn't been taken to master
> - Active preview for Babylon is not currently working for some reason.  More investgiation needs to happen.
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this issue Jun 5, 2017
@HowardWolosky
Update the Cesium and Babylon engines / Make Babylon work on unsaved …
e627746 
…changes

* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).
* Babylon (like Cesium) now defaults to previewing the content in the tab as opposed to the content saved in the file, the same way it's done in this [Babylon Plaground Example](https://www.babylonjs-playground.com/#1AbIIF#7).

Resolves Issue AnalyticalGraphicsInc#15

> **Work in Progress**
> - Active preview for Babylon is not currently working for some reason.  More investgiation needs to happen.
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this issue Jun 5, 2017
@HowardWolosky
Update the Cesium and Babylon engines
199b646 
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).

Resolves Issue AnalyticalGraphicsInc#15
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this issue Jun 5, 2017
@HowardWolosky
Update the Cesium and Babylon engines
ec3875b 
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).

Resolves Issue AnalyticalGraphicsInc#15
@HowardWolosky HowardWolosky mentioned this issue Jun 5, 2017
Merged
HowardWolosky added a commit to HowardWolosky/gltf-vscode that referenced this issue Jun 5, 2017
@HowardWolosky
Update the Cesium and Babylon engines
ed5b27e 
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`.
* Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222).

Resolves Issue AnalyticalGraphicsInc#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors type - enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjcozzi @HowardWolosky